-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: jwplayer embed #2505
Comments
This is probably better raised as a Core Trac ticket. |
This feels like plugin territory to me. |
@carstenheisterkamp Doesn't the Custom HTML block work for this? Maybe we need to make it a bit clearer that you can use it for embed codes too. |
@iseulde yes, technically this works with both the js and the iframe embed code. But you won´t have a preview of the video in the Gutenberg editor and it doesn´t have the nice one click add usability. |
Does the preview button not work? Similar to the the embed block, you have to paste the code, then click preview? Maybe we should persist that though. |
Just double checked it and honestly I totally overlooked the preview button... For iframe it works very well. The js code doesn´t sho a preview. The JS looks like this Is a formatting left/right/center/wide/full planned for the custom html block? This would help to define the width of the video. Currently it is full width only (or I am overlooking something again ;-) ) |
Yeah, if we detect scripts we probably need to iframe it. This would work: <iframe srcdoc="<script src="//content.jwplatform.com/players/foUW87lp-e0pTZRtU.js"></script>"></iframe> (Would need to be resized as well.) Or we need a separate block for admins only that handles all of this. |
I think this is dealt with the custom HTML block. If that is not the case, let me know and we can reopen. |
Jwplayer is a broadly used Video delivery platform which would be useful as an additional embed block. The default embed block can´t be used, since it provides Javascript as embed link or iFrame.
The text was updated successfully, but these errors were encountered: