Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should styles/padding sidebar panels be available for placeholders? #23122

Closed
richtabor opened this issue Jun 12, 2020 · 2 comments
Closed

Should styles/padding sidebar panels be available for placeholders? #23122

richtabor opened this issue Jun 12, 2020 · 2 comments
Labels
Needs Dev Ready for, and needs developer efforts

Comments

@richtabor
Copy link
Member

We don't show block settings for blocks that utilize placeholders (Image & Cover for example).

Should we also not show the block's Styles panel, and incoming Spacing panel?

The Styles and Spacing panels do not perform any action at that point; only when the placeholder's requirement is fulfilled.

Screenshots
Screen Shot 2020-06-12 at 3 07 50 PM
Screen Shot 2020-06-12 at 3 09 17 PM
@richtabor richtabor added the Needs Design Feedback Needs general design feedback. label Jun 12, 2020
@richtabor richtabor mentioned this issue Jun 17, 2020
Open
@enriquesanchez
Copy link
Contributor

Agreed these settings should not be available while the block is in its placeholder state.

@enriquesanchez enriquesanchez added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Aug 18, 2020
@bi0xid bi0xid mentioned this issue Dec 13, 2020
Closed
4 tasks
@Mamaduka Mamaduka mentioned this issue Jul 21, 2021
Open
7 tasks
@ntsekouras ntsekouras mentioned this issue Aug 2, 2021
Closed
7 tasks
@getsource
Copy link
Member

It looks like a decision was made here not to fix this issue, because the behavior is dependent on user workflows, and individual Blocks:
#33823 (comment)
#33823 (comment)

Should this issue be closed based on that?

@talldan talldan mentioned this issue Aug 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Dev Ready for, and needs developer efforts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@getsource @richtabor @enriquesanchez