Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation] Don't publish directly and don't render drafts #20282

Closed
draganescu opened this issue Feb 18, 2020 · 1 comment · Fixed by #27207
Closed

[Navigation] Don't publish directly and don't render drafts #20282

draganescu opened this issue Feb 18, 2020 · 1 comment · Fixed by #27207
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@draganescu
Copy link
Contributor

draganescu commented Feb 18, 2020

Is your feature request related to a problem? Please describe.
#19775 introduced the possibility to create a page directly from the block. By default the status of this page is published. This results in the situation that as soon as the place where the Navigation block is saved users of the website will be able to click on a navigation menu item that leads to an empty page.

Describe the solution you'd like
I would suggest that the Navigation block does not publish pages, but instead it creates drafts.
Drafts should be visible, but visually marked as drafts in the Navigation block.
When the Navigation block is deselected drafts should not be visible.
On the server when the navigation block is rendering, if the current NavigationLink is a page, it's status should be checked and if it is not published it shouldn't be rendered.

@draganescu draganescu added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block labels Feb 18, 2020
@noisysocks
Copy link
Member

Creating the page as a draft makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
2 participants