Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest posts: Notice: Undefined index: $attributes['layout'] #2010

Closed
afercia opened this issue Jul 25, 2017 · 1 comment
Closed

Latest posts: Notice: Undefined index: $attributes['layout'] #2010

afercia opened this issue Jul 25, 2017 · 1 comment
Assignees
@westonruter
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 25, 2017

I'm getting a PHP notice in the admin for a post that contains a Latest Posts Block:
Notice: Undefined index: layout in / ... /gutenberg/lib/blocks/latest-posts.php on line 74

seems to me introduced in 8580da5 where before checking for if ( 'grid' === $attributes['layout'] ) is probably necessary to check for isset().
@afercia afercia added the [Type] Bug An existing feature does not function as intended label Jul 25, 2017
@aduth aduth added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jul 25, 2017
@westonruter westonruter self-assigned this Jul 25, 2017
@westonruter
Copy link
Member

This is something else that would be unnecessary if we shared schema defaults between the client and server: #1905.

@westonruter westonruter mentioned this issue Jul 25, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westonruter westonruter

Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@westonruter @afercia @aduth