Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Top Toolbar" mode now has drag handle (broken) and arrows, should it? #19602

Closed
folletto opened this issue Jan 13, 2020 · 1 comment · Fixed by #20013
Closed

"Top Toolbar" mode now has drag handle (broken) and arrows, should it? #19602

folletto opened this issue Jan 13, 2020 · 1 comment · Fixed by #20013
Assignees
@epiqueras
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@folletto
Copy link
Contributor

Describe the bug
When in "Top Toolbar" mode, the moving handle and arrows are now in the toolbar too, which:

  1. It's buggy, as the drag handle doesn't work anymore
  2. It's not ideal, because even if it worked, it moved the handle away from where the drag should happen, and having 3 more buttons up there takes away a lot more space for the toolbar.

Screenshot 2020-01-13 at 18 59 12

To reproduce
Steps to reproduce the behavior:

  1. Create new post
  2. Set the toolbar to "Top Toolbar"
  3. Try to write a few paragraphs
  4. Try to move a paragraph with the drag handle.

Expected behavior
The arrows and drag handle should be near the block (left side):

Screenshot 2020-01-13 at 19 03 38

Desktop (please complete the following information):

  • macOS 10.15.2
  • Chrome 79.0.3945.117
@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. labels Jan 15, 2020
@epiqueras epiqueras added the Needs Design Feedback Needs general design feedback. label Jan 26, 2020
@epiqueras
Copy link
Contributor

Maybe we should keep the arrows at the top and hide the drag handler?

@epiqueras epiqueras self-assigned this Feb 3, 2020
@epiqueras epiqueras mentioned this issue Feb 3, 2020
Merged
6 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 3, 2020
@naiba4 naiba4 mentioned this issue Jan 4, 2024
Open
@MaxMood96 MaxMood96 mentioned this issue Jan 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epiqueras epiqueras

Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Edit Post: Hide block drag handle in top toolbar. WordPress/gutenberg
3 participants
@folletto @youknowriad @epiqueras