Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Toolbars: Reposition block toolbars to ensure they render within the viewport #18223

Closed
shaunandrews opened this issue Oct 31, 2019 · 2 comments · Fixed by #19344
Closed

Block Toolbars: Reposition block toolbars to ensure they render within the viewport #18223

shaunandrews opened this issue Oct 31, 2019 · 2 comments · Fixed by #19344
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript General Interface Parts of the UI which don't fall neatly under other labels. Needs Dev Ready for, and needs developer efforts

Comments

@shaunandrews
Copy link
Contributor

image

Depending on the viewport width, the placement of the block, and the length of the toolbar — its not uncommon to see the toolbar renders outside the visible space on the screen. Right now this adds a horizontal scrollbar to the entire document.

Instead, I'd expect the toolbar to move itself to ensure it displays within the viewport. Something like this:

image
@shaunandrews shaunandrews added Framework Issues related to broader framework topics, especially as it relates to javascript General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. labels Oct 31, 2019
@morgandruscarr
Copy link

Yes, that's a great idea.

@karmatosed karmatosed added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Nov 3, 2019
@jasmussen
Copy link
Contributor

This is fixed by #18685 as of #18685 (comment)

This was referenced Jan 15, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript General Interface Parts of the UI which don't fall neatly under other labels. Needs Dev Ready for, and needs developer efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try G2 WordPress/gutenberg
Move the block movers to the block toolbar WordPress/gutenberg
4 participants
@shaunandrews @karmatosed @jasmussen @morgandruscarr