Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear dropzone in gallery #17605

Closed
karmatosed opened this issue Sep 26, 2019 · 4 comments
Closed

Unclear dropzone in gallery #17605

karmatosed opened this issue Sep 26, 2019 · 4 comments
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images Needs Design Feedback Needs general design feedback.

Comments

@karmatosed
Copy link
Member

I was doing a block test and for me the way this dropzone appears is unexpected.

image

I didn't expect to see buttons in what is a dropzone styling, which made me wonder could we move buttons out from this?

@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Sep 26, 2019
@mapk
Copy link
Contributor

mapk commented Oct 1, 2019

Good catch here. I no longer recognize this as a dropzone anymore now that it includes buttons.

This could use another redesign. Switching labels!

@mapk mapk added Needs Design Needs design efforts. and removed Needs Design Feedback Needs general design feedback. labels Oct 1, 2019
@enriquesanchez
Copy link
Contributor

Could we replicate what we already do in the block placeholder of images/galleries, etc?

Screen Shot 2019-10-07 at 2 30 32 PM

While there's no visible "drop zone", the whole area acts as one:

Screen Shot 2019-10-07 at 2 25 40 PM

So it could end up looking like this:

Screen Shot 2019-10-07 at 2 26 26 PM

In this mockup, I've moved 'Write gallery caption...' above the drop zone and closer to the images.

@mapk mapk added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Nov 21, 2019
@youknowriad youknowriad added the [Block] Gallery Affects the Gallery Block - used to display groups of images label Jan 17, 2020
@youknowriad
Copy link
Contributor

youknowriad commented Apr 1, 2020

Should we close this as a duplicate of #21247?

@karmatosed
Copy link
Member Author

I think so @youknowriad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

4 participants