Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets: Blocks areas need width/padding adjustments #16600

Closed
mapk opened this issue Jul 15, 2019 · 3 comments · Fixed by #16944
Closed

Widgets: Blocks areas need width/padding adjustments #16600

mapk opened this issue Jul 15, 2019 · 3 comments · Fixed by #16944
Assignees
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress

Comments

@mapk
Copy link
Contributor

mapk commented Jul 15, 2019

Some width and padding adjustments can help the new widgets screen visually.

The new widgets screen shows blocks areas in a narrow column that's set to max-width:610px and it also includes a large amount of padding on the left/right sides of the blocks.

Solutions

  1. Change the max-width of .edit-widgets-widget-area to 700px instead of 610px.
    Proposed:
    .edit-widgets-widget-area { max-width: 700px; }

  2. Remove the padding on left/right side of .block-editor-block-list__layout for this screen.
    Proposed:
    .block-editor-block-list__layout { padding-left:46px; padding-right:46px; }


Current appearance:

Screen Shot 2019-07-15 at 2 05 35 PM

Proposed appearance:

Screen Shot 2019-07-15 at 2 05 00 PM

@mapk mapk added Needs Design Feedback Needs general design feedback. [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Jul 15, 2019
@karmatosed
Copy link
Member

Thanks for reporting this. I agree so much it's better with less padding. I do wonder though, could you go a step further? What about aligning the edge to the text and arrow? Would that be too big a block space?

@youknowriad youknowriad added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jul 16, 2019
@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Jul 16, 2019
@mapk
Copy link
Contributor Author

mapk commented Jul 24, 2019

Here's an example of the blocks being wider.

Screen Shot 2019-07-24 at 7 09 16 AM

The block UI starts falling outside the Block Area. The additional padding on the left/right sides help keep this UI inside and mimic more of the Editor "feel" here. Let's keep the proposed appearance in the early mockup.

@karmatosed
Copy link
Member

The block UI starts falling outside the Block Area.

Ah good catch, in that case 100% agree with more padding.

@karmatosed karmatosed added the Needs Dev Ready for, and needs developer efforts label Aug 5, 2019
@jorgefilipecosta jorgefilipecosta self-assigned this Aug 7, 2019
@jorgefilipecosta jorgefilipecosta added the [Status] In Progress Tracking issues with work in progress label Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants