Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experiments settings page to the plugin #16318

Closed
karmatosed opened this issue Jun 26, 2019 · 17 comments
Closed

Add experiments settings page to the plugin #16318

karmatosed opened this issue Jun 26, 2019 · 17 comments
Assignees
Labels
Needs Decision Needs a decision to be actionable or relevant Needs Dev Ready for, and needs developer efforts [Type] Copy Issues or PRs that need copy editing assistance

Comments

@karmatosed
Copy link
Member

karmatosed commented Jun 26, 2019

Having a settings screen to enable experimental features could be good. This was discussed during WCEU contribution day and I have done 2 really rough starting mockups to begin the work on this.

First, there needs to be a link in the menu, I would suggest something like this (note that all copy needs working on in these examples):

Menu

I chose the word 'experiments' to avoid going onto 2 lines, settings could also work.

A simple settings page would contain all the options, off by default:

Settings page

What do people think? I would love specific feedback on the copy/ Style wise this does use the default wp-admin settings page which in this case probably makes sense to use over diverging.

@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Jun 26, 2019
@karmatosed karmatosed added the [Type] Copy Issues or PRs that need copy editing assistance label Jun 26, 2019
@paaljoachim
Copy link
Contributor

paaljoachim commented Jun 27, 2019

@karmatosed
I think this is a very good idea Tammie! When experimental features are created a check box can easily be added into the Experiments screen to turn on the specific feature. It makes testing a lot easier as I would then mainly focus on specific experiment I just activated. I also find the wording clear and straightforward.

@kjellr
Copy link
Contributor

kjellr commented Jul 2, 2019

This looks great. Would it be appropriate to include some sort of disclaimer about the experiments here? As in: They may have limited functionality, etc.

@richtabor
Copy link
Member

Just a thought, but if something like #16401 was available, the settings could be placed right within the editor - instead of having another admin page. 🤔

@youknowriad
Copy link
Contributor

@richtabor I think the issue, in that case, is that some of these experimental features go beyond the editor screen (widgets, customizer)

@richtabor
Copy link
Member

@richtabor I think the issue, in that case, is that some of these experimental features go beyond the editor screen (widgets, customizer)

Ah good point Riad. 👌

@noisysocks
Copy link
Member

Cool idea! Should it be a user setting or a site setting?

@youknowriad
Copy link
Contributor

I think a site setting makes more sense. What do you think?

@paaljoachim
Copy link
Contributor

Actually could a site setting become a very early exploration of a global setting?

@mapk
Copy link
Contributor

mapk commented Jul 10, 2019

@karmatosed's mockups here work great to get this going. I believe the word "experiments" is a great indicator that this section is hairy. Some added text on the page to further explain this as @kjellr pointed out is always a safe bet too.

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Jul 10, 2019
@tellthemachines
Copy link
Contributor

tellthemachines commented Jul 12, 2019

Hey @karmatosed should this page have a "save settings" button or should the settings automatically be saved on clicking the checkboxes?

Also, for the functionality that is already available: the widgets screen and legacy widgets block, should we now make them not available by default? My concern is anyone already using them might not know where they've gone. Or should we only add to this section new features as they become available?

@youknowriad
Copy link
Contributor

we now make them not available by default?

There's still the possibility to have an "upgrade" script explicitly adding the setting while by default when installing the plugin, it will be unchecked. But we still need to discuss the best default value. Being enabled by default might make sense.

@tellthemachines tellthemachines added Needs Design Feedback Needs general design feedback. Needs Decision Needs a decision to be actionable or relevant labels Jul 15, 2019
@karmatosed
Copy link
Member Author

@tellthemachines we should probably have 'save settings' as all other pages do. I wish we didn't have to :)

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Jul 15, 2019
@tellthemachines
Copy link
Contributor

@karmatosed it should be technically possible to not have the "save settings" button, the question is more should we stay consistent with the rest of wp-admin?

@karmatosed
Copy link
Member Author

@tellthemachines thanks for the confirmation, I agree as other pages have it we should also. Do you want me to mock that up or are you ok just adding in?

@tellthemachines
Copy link
Contributor

@tellthemachines thanks for the confirmation, I agree as other pages have it we should also. Do you want me to mock that up or are you ok just adding in?

@karmatosed happy to add it in, the styles are already there. I'll let you know when it's ready for a review 😄

@karmatosed
Copy link
Member Author

@tellthemachines thanks, that's great!

@tellthemachines
Copy link
Contributor

The experiments settings page has been merged, so we can close this now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Decision Needs a decision to be actionable or relevant Needs Dev Ready for, and needs developer efforts [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

No branches or pull requests

8 participants