Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockquote right align ouput #16027

Closed
timelsass opened this issue Jun 7, 2019 · 2 comments
Closed

blockquote right align ouput #16027

timelsass opened this issue Jun 7, 2019 · 2 comments
Labels
[Block] Quote Affects the Quote Block [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.

Comments

@timelsass
Copy link
Contributor

In looking at #11609 and #10970 neither seemed to address an issue I've been frequently running across for frontend output vs editor output.

I agree that the styling using something like [style*="text-align: right"] is a little hacky, but even in using it - the output on the frontend won't match that selector, and it has to be specified as [style*="text-align:right"] (no space). The editor view includes a space.

I think it would be a nice addition to have the alignments handle via a class overall, but in the very least having the output for the inline style consistent would be helpful. Sure a heavier selector could be used like [style*="right"][style*="text-align"] but that is still error prone leaving something like [style*="text-align: right"],[style*="text-align:right"] as being the only somewhat safe solution to cover both scenarios.

@swissspidy swissspidy added [Block] Quote Affects the Quote Block [Type] Help Request Help with setup, implementation, or "How do I?" questions. labels Jun 7, 2019
@gziolo
Copy link
Member

gziolo commented Jun 10, 2019

I'm proposing a fix which could get applied to all blocks which use text alignment in #16035.

@gziolo gziolo added [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement. and removed [Type] Help Request Help with setup, implementation, or "How do I?" questions. labels Jun 10, 2019
@timelsass
Copy link
Contributor Author

@gziolo that resolves this issue (and some other conflicts I had but did't report since I assumed that a solution like that would be the right approach) - I'm going to close this issue, thanks for taking the time and working on this solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Quote Affects the Quote Block [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants