Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery: full-screen image preview #1453

Closed
nylen opened this issue Jun 26, 2017 · 4 comments
Closed

Gallery: full-screen image preview #1453

nylen opened this issue Jun 26, 2017 · 4 comments
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.

Comments

@nylen
Copy link
Member

nylen commented Jun 26, 2017

It would be nice to be able to view gallery images without leaving the page that contains the gallery. A couple of examples in the wild:

While this feature is supported in Jetpack, I think it would be a great fit for Gutenberg, and common enough to warrant inclusion in core.

@nylen nylen added [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement. labels Jun 26, 2017
@swissspidy
Copy link
Member

Tiled Galleries is not a good example… Did you perhaps mean https://jetpack.com/support/carousel/ instead?

Could the same be done for single images as well? It's something many people implement on their sites using the dozens of lightbox plugins out there.

@afercia
Copy link
Contributor

afercia commented Jun 28, 2017

As accessibility team, we've recently been asked for some advice about "image carousels" for a meta ticket, and done some research, see:

Improve Screenshot Slider Accessibility
https://meta.trac.wordpress.org/ticket/2654
(reading references posted there highly recommended)

In short, one of the most accessible carousels I've personally seen is:
https://jongund.github.io/aria-examples/bootstrap-carousel/carousel-3.html

There may be others, so any feedback welcome!

@mtias mtias added the [Feature] Media Anything that impacts the experience of managing media label Jun 29, 2017
@karmatosed
Copy link
Member

I think this would be nice. In a way it would help with the feeling of a front/back being the same. I do think we need to be cautious though of how this is done - with a11y mindfulness.

@karmatosed karmatosed added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Aug 3, 2017
@mtias
Copy link
Member

mtias commented Jan 4, 2018

Closing as we are likely not going to get to front-end improvements like this one and it'll remain plugin territory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants