-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List Block: add type attribute for ordered list #13888
Comments
This seems like something that could easily be added. |
Hi @ellatrix does this mean we need to create list settings in the sidebar like below? |
Exactly :) |
@ellatrix I create a pr to fix this issue. There is still some work left to be done. I will continue to work on this. But I would really appreciate if you could provide some early feedback. |
The attributes have been added except for |
@Jackie6, thanks for working on this! My one note is that — for good accessibility — the Type control be a native selectbox component, similarly to how it’s used for the Image size and Default style selections. |
I am interested in seeing the additional list types in Gutenberg, willing to help move this forward where possible, and learned that @Jackie6 has added this in this PR but it was later reverted before the PR was merged. @ellatrix asked for it to be made in a new PR which doesn't appear to have been made yet. From the discussion on that PR (specifically this from @ellatrix , it sounds like the next steps that are needed going forward are:
Additional references: |
As mentioned above, @ellatrix had mentioned the ordered list styles to be made in a new PR, so I began to re-implement it but there have been quite a bit that has changed (files being moved, etc) in just a few months. I think I figured out where and how to rewrite that code but there was code in packages/rich-text/src/component/editable.js but that file has since been removed from Gutenberg (d9de027 Right now, I receive an ReferenceError that type is not defined. My code is at https://github.com/skorasaurus/gutenberg/tree/add/list-other-styles |
Is it possible that this issue was already solved by: |
I think this can be closed because all of those features (what 'number' to start an ordered list, numbering style (Roman Number, and lower case roman numeral), and reverse order) have all been implemented in Gutenberg for some time. |
Is your feature request related to a problem? Please describe.
I was writing a legal document and I could not choose if the list needs to be in numbers, words or any other type possible. I had to write the whole thing in one LIST block because there is no "start" option also.
Describe the solution you'd like
I would like to add attributes of an OL element as Block options so those are:
reversed
,type
andstart
.Describe alternatives you've considered
This can be done using the HTML of the block and changing it but this can be an issue when reloading the page since the save method might not take that into account.
And if you don't know HTML like regular users, there is no way of changing that.
The text was updated successfully, but these errors were encountered: