Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the 'Hide the teaser' option in the more block #12785

Closed
maddisondesigns opened this issue Dec 11, 2018 · 6 comments
Closed

Clarify the 'Hide the teaser' option in the more block #12785

maddisondesigns opened this issue Dec 11, 2018 · 6 comments
Labels
[Block] More Affects the More Block - used for displaying the 'Read More' link

Comments

@maddisondesigns
Copy link

Describe the bug
The More Block provides a toggle switch to Hide the teaser before the "More" tag.

Presumably, this should hide the excerpt on the archive page, rather than show it, but at the moment, the switch doesn't do anything.

Toggled on:
screenshot_1012

Toggled off:
screenshot_1011

Instead of fixing this switch, it should just be removed altogether, as it's counterintuitive to the functionality of the whole block. The point of the More Block (like the More Tab in the Classic Editor), is to specify the position where the excerpt should stop (on archive pages).

If you don't want any excerpt to display, then you would simply insert the More tag at the very top of your Post. There is no need for this toggle switch and it's just a confusing option.

To Reproduce
Steps to reproduce the behavior:

  1. Edit a Post
  2. Insert a More Block where you want the excerpt to stop
  3. Toggle the 'Hide the Teaser' switch to on
  4. View your blog page and see that the excerpt still appears

Desktop (please complete the following information):

  • macOS Sierra
  • Firefox Quantum 63.0.3
  • WP 5.0
@swissspidy
Copy link
Member

Presumably, this should hide the excerpt on the archive page, rather than show it, but at the moment, the switch doesn't do anything.

No. This option hides the excerpt when viewing the single post.

So if your post content looks like this:

Foo

[more block]

Bar

In the archive page you'll see Foo (read more), and on the single post page you should just see Bar

@swissspidy swissspidy added the [Block] More Affects the More Block - used for displaying the 'Read More' link label Dec 11, 2018
@maddisondesigns
Copy link
Author

Ahh ok. Thanks for clarifying this.

This functionality seems kinda weird though. The 'More tag' has always related to how the content displays on the archive page, and nothing to do with how it displays on the Single Post page. Even the description for this block, specifically mentions the archives page, yet this option affects how it displays on the Single Post page. If you want a Custom Excerpt (that doesn't display on the Single Post), there's already a specific field for that functionality.

@swissspidy
Copy link
Member

This functionality seems kinda weird though. The 'More tag' has always related to how the content displays on the archive page, and nothing to do with how it displays on the Single Post page.

The behavior of that teaser toggle is exactly the same as before in WordPress core. You can look for noteaser in get_the_content() to see how it works.

Sounds like the wording is inaccurate then.

@maddisondesigns
Copy link
Author

Fair enough. Thanks for pointing that out. In twelve years of using WordPress I don't think I've ever seen a theme that actually strips that teaser.

It might be worth making that toggle switch wording a little clearer, as it's a bit confusing as to what it's supposed to do. Maybe something like 'Hide the teaser before the "More" tag on Single Post pages'

@youknowriad youknowriad changed the title 'Hide the teaser' switch on More Block does nothing Clarify the 'Hide the teaser' option in the more block Dec 26, 2018
@afercia
Copy link
Contributor

afercia commented Dec 28, 2018

Yep the wording is slightly 😆confusing. See also #8974 (comment)

@ntsekouras
Copy link
Contributor

This has been resolved here: #13630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] More Affects the More Block - used for displaying the 'Read More' link
Projects
None yet
Development

No branches or pull requests

4 participants