Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Reduced responsiveness when using Annotations API #12642

Closed
moorscode opened this issue Dec 6, 2018 · 2 comments
Closed

Performance: Reduced responsiveness when using Annotations API #12642

moorscode opened this issue Dec 6, 2018 · 2 comments
Labels
[Feature] Annotations Adding annotation functionality [Type] Performance Related to performance efforts

Comments

@moorscode
Copy link
Contributor

Describe the bug

Since Yoast SEO 9.2 we have implemented the annotations API support.
This results in reduced responsiveness when typing, at least in two situations:

  • When typing really fast
  • When moving the cursor while typing

Which suggests that the problem is only amplified by doing faster or more actions together.

Events that are used (extracted from profiling in the browser):
Mouse movement: Gutenberg/editor/index.js: stopTypingOnMouseMove
Fast typing: Gutenberg/editor/index.js: key: "render"

Maybe related:
When using Yoast SEO 9.1 (no annotations API) the following issue manifests itself after ~26 items in the How-To block instead of ~15

To Reproduce
Steps to reproduce the behavior:

  1. Type really fast (button-bash) - in gradual amounts the text is starting to stagger more and eventually just does not update until you stop typing

Or

  1. Type with one hand and keep moving the mouse with the other
  2. The text will not be updated until after the mouse has stopped moving

Expected behavior
I expect the text to be updated and rendered whenever I type.

Screenshots

When moving the mouse while typing, these are the performance tab results:
typing-while-mouse-movement

When typing very quickly, these are the performance tab results:
very-quick-typing

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Chrome
  • Version 71

Additional context

Related issue on Yoast SEO: Yoast/wordpress-seo#11772

@atimmer
Copy link
Member

atimmer commented Dec 6, 2018

This is most probably fixed by #12186.

@danielbachhuber danielbachhuber added [Type] Performance Related to performance efforts [Feature] Annotations Adding annotation functionality labels Dec 6, 2018
@aduth
Copy link
Member

aduth commented Dec 14, 2018

Considering as fixed by #12161, #12741. Please reopen if it remains an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Annotations Adding annotation functionality [Type] Performance Related to performance efforts
Projects
None yet
Development

No branches or pull requests

4 participants