Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons: New icon for paragraph and preformatted #1249

Closed
jasmussen opened this issue Jun 19, 2017 · 8 comments
Closed

Icons: New icon for paragraph and preformatted #1249

jasmussen opened this issue Jun 19, 2017 · 8 comments
Labels
[Feature] Blocks Overall functionality of blocks

Comments

@jasmussen
Copy link
Contributor

Right now we use the same text icon for text, freeform and preformatted:

screen shot 2017-06-19 at 10 34 57

We should consider renaming Text to "Paragraph", and give it a paragraph icon, like the early mockups:

screen shot 2017-06-19 at 10 36 17

We should also give preformatted a new icon. Maybe one of these? https://developer.wordpress.org/resource/dashicons/#media-code — CC: @field2 for input.

@buzztone
Copy link

I feel this issue would be significantly improved by finding more appropriate icons for freeform and preformatted blocks. They definitely need to be different.

@buzztone
Copy link

buzztone commented Jun 21, 2017

I don't feel Paragraph is a suitable name for the Text block.

When I Insert a Text block, I get a series of options in the first drop-down menu that are not paragraphs.

2017-06-21_01a

I see Paragraph as 1 of the options in that list - though it is the default option & not listed.

A related issue that occurs to me is how does a user change from a Quote back to Paragraph? Perhaps it makes sense to add Paragraph as the default selected option in the first drop-down menu with the proposed Paragraph icon.

@youknowriad
Copy link
Contributor

When I Insert a Text block, I get a series of options in the first drop-down menu that are not paragraphs.

FWIW Te first drop-down menu in the block toolbar is what we call the "Block Switcher". It's a menu to switch to another block. Thus, it's not really options for the current block.

@jasmussen
Copy link
Contributor Author

Yep, that's the switcher component. But I think it might be worth revisiting #493. Going to mock up a thing there.

@buzztone
Copy link

buzztone commented Jun 21, 2017

Thus, it's not really options for the current block.

Interesting - I'm still a new user at this stage & I was sure the Block Switcher was a drop-down list of options available for the Block type I'd selected.

For me this interpretation was confirmed by the items shown being all html text formatting tags.

Now that you've given it a name & explained it's purpose I can see it from that perspective - but I definitely didn't interpret it that way.

I think the fact that I'd selected a Text block locked me into thinking that whatever followed, in terms of options, was based on the selected block type.

It might be useful to see if other new users make similar assumptions.

@buzztone
Copy link

buzztone commented Jun 21, 2017

The first drop-down menu in the block toolbar is what we call the "Block Switcher".

Could be helpful for new contributors to add diagram showing terms used by the development team to describe the UI at http://gutenberg-devdoc.surge.sh

ui_blueprint

@jasmussen
Copy link
Contributor Author

Great point. Will do that.

@jasmussen
Copy link
Contributor Author

Closing as fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

No branches or pull requests

3 participants