Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the effects into async actions with controls #11124

Closed
youknowriad opened this issue Oct 26, 2018 · 2 comments
Closed

Refactor the effects into async actions with controls #11124

youknowriad opened this issue Oct 26, 2018 · 2 comments
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Package] Data /packages/data [Type] Code Quality Issues or PRs that relate to code quality

Comments

@youknowriad
Copy link
Contributor

Now that we have controls and actions as generators, we should refactor all of our current effects to use this pattern instead.

A small technical requirement to make it possible is the possibility to pass the "registry" object to the controls.
@youknowriad youknowriad added Framework Issues related to broader framework topics, especially as it relates to javascript [Package] Data /packages/data labels Oct 26, 2018
@youknowriad youknowriad changed the title Refactor the effects into controls Refactor the effects into async actions with controls Oct 26, 2018
@youknowriad youknowriad mentioned this issue Oct 26, 2018
Merged
@nerrad nerrad mentioned this issue Feb 8, 2019
Merged
8 tasks
@youknowriad youknowriad added the [Type] Code Quality Issues or PRs that relate to code quality label Feb 8, 2019
@noisysocks noisysocks mentioned this issue Feb 13, 2019
Closed
@paaljoachim
Copy link
Contributor

Is this issue still relevant @youknowriad ?

@youknowriad
Copy link
Contributor Author

Actually, we've refactored all of these now. So we should be good, there's some remaining cleanup that I'll take care of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Package] Data /packages/data [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@youknowriad @paaljoachim