Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to Media & Text block keyword 'half' #10856

Closed
Soean opened this issue Oct 21, 2018 · 2 comments
Closed

Add context to Media & Text block keyword 'half' #10856

Soean opened this issue Oct 21, 2018 · 2 comments
Assignees
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Internationalization (i18n) Issues or PRs related to internationalization efforts

Comments

@Soean
Copy link
Member

Soean commented Oct 21, 2018

Describe the bug
Media & Text block introduced in 4.1., adds the keyword half. The german polyglots team wasn't able to translate the string because of missing context. So we should add a context.

@Soean Soean added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Oct 21, 2018
@swissspidy
Copy link
Member

I think it's we should remove that keyword entirely.

Looking at the code I have no idea what it means. Half media and half text? According to #9416 the block was referred to "half image layout" once. But that's not really useful for a user and not something I would actually type in to search for a media and text block.

@mtias
Copy link
Member

mtias commented Oct 23, 2018

I agree we should remove "half".

@swissspidy swissspidy added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Oct 23, 2018
@Soean Soean self-assigned this Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Development

No branches or pull requests

3 participants