Blocks: Addressed feedback related to BlockEditContext changes

WordPress · Apr 16, 2018 · cf63e10 · cf63e10
1 parent fbb66c8
commit cf63e10
Show file tree

Hide file tree

Showing 3 changed files with 59 additions and 56 deletions.
diff --git a/blocks/library/paragraph/index.js b/blocks/library/paragraph/index.js
@@ -226,40 +226,42 @@ class ParagraphBlock extends Component {
 						/>
 					</PanelBody>
 				</InspectorControls>
-				<RichText
-					tagName="p"
-					className={ classnames( 'wp-block-paragraph', className, {
-						'has-background': backgroundColor,
-						'has-drop-cap': dropCap,
-					} ) }
-					style={ {
-						backgroundColor: backgroundColor,
-						color: textColor,
-						fontSize: fontSize ? fontSize + 'px' : undefined,
-						textAlign: align,
-					} }
-					value={ content }
-					onChange={ ( nextContent ) => {
-						setAttributes( {
-							content: nextContent,
-						} );
-					} }
-					onSplit={ insertBlocksAfter ?
-						( before, after, ...blocks ) => {
-							setAttributes( { content: before } );
-							insertBlocksAfter( [
-								...blocks,
-								createBlock( 'core/paragraph', { content: after } ),
-							] );
-						} :
-						undefined
-					}
-					onMerge={ mergeBlocks }
-					onReplace={ this.onReplace }
-					onRemove={ () => onReplace( [] ) }
-					placeholder={ placeholder || __( 'Add text or type / to add content' ) }
-					autocompleters={ autocompleters }
-				/>
+				<div>
+					<RichText
+						tagName="p"
+						className={ classnames( 'wp-block-paragraph', className, {
+							'has-background': backgroundColor,
+							'has-drop-cap': dropCap,
+						} ) }
+						style={ {
+							backgroundColor: backgroundColor,
+							color: textColor,
+							fontSize: fontSize ? fontSize + 'px' : undefined,
+							textAlign: align,
+						} }
+						value={ content }
+						onChange={ ( nextContent ) => {
+							setAttributes( {
+								content: nextContent,
+							} );
+						} }
+						onSplit={ insertBlocksAfter ?
+							( before, after, ...blocks ) => {
+								setAttributes( { content: before } );
+								insertBlocksAfter( [
+									...blocks,
+									createBlock( 'core/paragraph', { content: after } ),
+								] );
+							} :
+							undefined
+						}
+						onMerge={ mergeBlocks }
+						onReplace={ this.onReplace }
+						onRemove={ () => onReplace( [] ) }
+						placeholder={ placeholder || __( 'Add text or type / to add content' ) }
+						autocompleters={ autocompleters }
+					/>
+				</div>
 			</Fragment>
 		);
 	}

diff --git a/blocks/library/paragraph/test/__snapshots__/index.js.snap b/blocks/library/paragraph/test/__snapshots__/index.js.snap
@@ -3,29 +3,31 @@
 exports[`core/paragraph block edit matches snapshot 1`] = `
 <div>
    
-  <div
-    class="blocks-rich-text"
-  >
-    <div>
+  <div>
+    <div
+      class="blocks-rich-text"
+    >
       <div>
-        <div
-          class="components-autocomplete"
-        >
-          <p
-            aria-autocomplete="list"
-            aria-expanded="false"
-            aria-label="Add text or type / to add content"
-            aria-multiline="false"
-            class="wp-block-paragraph blocks-rich-text__tinymce"
-            contenteditable="true"
-            data-is-placeholder-visible="true"
-            role="textbox"
-          />
-          <p
-            class="blocks-rich-text__tinymce wp-block-paragraph"
+        <div>
+          <div
+            class="components-autocomplete"
           >
-            Add text or type / to add content
-          </p>
+            <p
+              aria-autocomplete="list"
+              aria-expanded="false"
+              aria-label="Add text or type / to add content"
+              aria-multiline="false"
+              class="wp-block-paragraph blocks-rich-text__tinymce"
+              contenteditable="true"
+              data-is-placeholder-visible="true"
+              role="textbox"
+            />
+            <p
+              class="blocks-rich-text__tinymce wp-block-paragraph"
+            >
+              Add text or type / to add content
+            </p>
+          </div>
         </div>
       </div>
     </div>

diff --git a/docs/deprecated.md b/docs/deprecated.md
@@ -9,7 +9,6 @@ Gutenberg's deprecation policy is intended to support backwards-compatibility fo
 ## 2.7.0
 
 - `wp.element.getWrapperDisplayName` function removed. Please use `wp.element.createHigherOrderComponent` instead.
-- `isSelected` usage is no longer mandatory with `BlockControls`, `InspectorControls` and `RichText`. It is now handled by the editor internally to ensure that controls are visible only when block is selected. See updated docs: https://github.com/WordPress/gutenberg/blob/master/blocks/README.md#components.
 
 ## 2.6.0