Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included i18n examples will not work as expected #1

Closed
nylen opened this issue Aug 14, 2017 · 1 comment
Closed

Included i18n examples will not work as expected #1

nylen opened this issue Aug 14, 2017 · 1 comment

Comments

@nylen
Copy link
Member

nylen commented Aug 14, 2017

Originally reported by @aduth at nylen/gutenberg-examples#9


Reported at: Automattic/jetpack#7597 (comment)

Example: https://github.com/nylen/gutenberg-examples/blob/6e369f8/01-basic/block.js#L20

The wp.i18n.__ function does not accept a domain (second parameter). i18n domain has yet to be implemented for these functions, and is still up in the air whether this is to be performed as part of the runtime call or during a build step.

See also: https://github.com/WordPress/gutenberg/tree/master/i18n

@mattyrob
Copy link

mattyrob commented Apr 4, 2018

It looks like this was fixed upstream with:
WordPress/gutenberg#5235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants