Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostsPerPageSniff.php does not catch the -1 if the line is not followed by a comma #1505

Closed
GaryJones opened this issue Oct 18, 2018 · 2 comments
Milestone

Comments

@GaryJones
Copy link
Member

Original Issue: Automattic/VIP-Coding-Standards#29

Rejected PR: #1297

The sniff catches following:

<?php

$args = array(
    'posts_per_page' => -1,
);

but not following:

<?php

$args = array(
    'posts_per_page' => -1
);

Reporting here as a reminder to investigate and reproduce this.

@dingo-d
Copy link
Member

dingo-d commented Dec 9, 2022

This is no longer reproducible since PR #1260 and the VIP part was removed in #1551. So we will close this issue.

@dingo-d dingo-d closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2022
@jrfnl
Copy link
Member

jrfnl commented Jul 4, 2023

This is actually a real bug, which was also reported in #2211 and will be fixed by open PR #2266.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants