Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Remaining VIP Sniffs and Deprecate #1409

Closed
tomjn opened this issue Jul 3, 2018 · 5 comments
Closed

Migrate Remaining VIP Sniffs and Deprecate #1409

tomjn opened this issue Jul 3, 2018 · 5 comments
Labels
Type: Chores/Cleanup
Milestone
1.0.0

Comments

@tomjn
Copy link
Contributor

tomjn commented Jul 3, 2018

Currently these sniffs in WordPress/Sniffs/VIP need to be migrated to other rulesets and deprecated:

  • SuperGlobalInputUsageSniff
  • SessionVariableUsageSniff
  • SessionFunctionsUsageSniff
  • RestrictedVariablesSniff
  • RestrictedFunctionsSniff
  • OrderByRandSniff
  • FileSystemWritesDisallowSniff
  • AdminBarRemovalSniff

The RestrictedFunctionsSniff seems an odd one out in that it's very VIP context specific, and references a lot of VIP functions unique to WordPress.com. It might be a candidate for deprecation without migration, or at the least behaviour modification
@tomjn tomjn mentioned this issue Jul 3, 2018
Merged
@jrfnl
Copy link
Member

jrfnl commented Jul 3, 2018

@tomjn Note: most of these should not be migrated to other rulesets as they are too VIP specific. Most sniffs which should be migrated, have already been handled in #1157 / #1242.

@tomjn
Copy link
Contributor Author

tomjn commented Jul 3, 2018

Ah then I shall work on just the deprecation part :)

@tomjn
Copy link
Contributor Author

tomjn commented Jul 6, 2018

order by rand might want to be included in the future as the problem isn't VIP specific, but it will need a non-VIP specific solution in the suggestion

@jrfnl
Copy link
Member

jrfnl commented Jul 6, 2018

Related #1309

This was referenced Jul 6, 2018
Closed
Closed
Closed
@jrfnl
Copy link
Member

jrfnl commented Jul 16, 2018

Closing now #1310 has been merged.

@jrfnl jrfnl closed this as completed Jul 16, 2018
@jrfnl jrfnl added this to the 1.0.0 milestone Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Chores/Cleanup
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@tomjn @jrfnl