Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Support KCL Version 2.x #68

Open
aquamatthias opened this issue Sep 3, 2018 · 5 comments
Open

Support KCL Version 2.x #68

aquamatthias opened this issue Sep 3, 2018 · 5 comments

Comments

@aquamatthias
Copy link
Contributor

Looks like the AWS guys improved KCL: KCL 2.0 uses async IO with HTTP/2.
Would be great to see support in reactive-kinesis for this.

Migration guide from 1.x to 2.x: https://docs.aws.amazon.com/streams/latest/dev/kcl-migration.html

@markglh
Copy link
Contributor

markglh commented Sep 3, 2018

Agreed, I've been waiting for this to be released and stabilise - we've used the underlying sdk 2 in a few projects now and it seems to be just about there. Lot of fixes in kcl 2.0.1:
https://github.com/awslabs/amazon-kinesis-client/releases

I'll look into what this entails and figure out an approach. It's definitely gonna be breaking...

@lxwbr
Copy link

lxwbr commented Mar 7, 2019

Hey @markglh just wondering if you had time to make some progress on the migration yet.

@agaro1121
Copy link
Contributor

We're splitting the consumer and producer into separate modules so we can evolve them separately. I have a PR open for this, once we merge it in, the upgrade to KCL should be a little easier

@etspaceman
Copy link
Contributor

Something to keep in mind with this is that kinesalite does not currently support the 2.x API.

mhart/kinesalite#75

@etspaceman
Copy link
Contributor

You can get the V2 library to work w/ localstack (kinesalite), see comment here:

localstack/localstack#893 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

5 participants