Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web App Translations: Consider adding start_url as a supported member #45

Open
aarongustafson opened this issue Nov 19, 2021 · 2 comments

Comments

@aarongustafson
Copy link
Collaborator

Autoscrib uses this setup to indicate alternate translations of their app:

<link id="metaHrefFr" rel="alternate" hreflang="fr" href="https://autoscrib.com/home/fr/">
<link id="metaHrefIt" rel="alternate" hreflang="it" href="https://autoscrib.com/home/it/">
<link id="metaHrefEn" rel="alternate" hreflang="en" href="https://autoscrib.com/home/en/">
<link id="metaHrefDef" rel="alternate" hreflang="x-default" href="https://autoscrib.com/home/en/">

In each app, they link to a language-specific Manifest. With translations they should be able to have a single Manifest file for their app and if we enable start_url to be overridden per-language, they could roll these meta values into the Manifest and maintain them in a single place.

@loubrett
Copy link
Collaborator

Good point, that seems reasonable to add to translations.

start_url is currently used as the app_id, so we would need to ensure that translating the start_url doesn't change the app_id. We would also need to ensure all start_urls are on the same origin for security.

@dmurph
Copy link
Collaborator

dmurph commented Nov 22, 2021

To avoid the id issue, you could require that an id field is set in order to support the translations field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants