From 1e243f1cd33ef87586291f221eb5ec1ece123c62 Mon Sep 17 00:00:00 2001 From: Smart-Codi Date: Thu, 14 Apr 2022 13:46:32 -0400 Subject: [PATCH] fix: Line Chart Annotation Info Update (#19001) * fix Line Chart Annotation Info Updage * wrap annotation text with transation * resolve comment --- .../AnnotationLayerControl/AnnotationLayer.jsx | 12 +++++++----- superset/translations/zh/LC_MESSAGES/messages.json | 4 ++-- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx b/superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx index e91e3b647355b..c45afb28ec8ec 100644 --- a/superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx +++ b/superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx @@ -383,11 +383,13 @@ export default class AnnotationLayer extends React.PureComponent { description = 'Select the Annotation Layer you would like to use.'; } else { label = t('Chart'); - description = `Use a pre defined Superset Chart as a source for annotations and overlays. - your chart must be one of these visualization types: - [${this.getSupportedSourceTypes(annotationType) - .map(x => x.label) - .join(', ')}]`; + description = t( + `Use another existing chart as a source for annotations and overlays. + Your chart must be one of these visualization types: [%s]`, + this.getSupportedSourceTypes(annotationType) + .map(x => x.label) + .join(', '), + ); } } else if (annotationType === ANNOTATION_TYPES.FORMULA) { label = 'Formula'; diff --git a/superset/translations/zh/LC_MESSAGES/messages.json b/superset/translations/zh/LC_MESSAGES/messages.json index 3b3157bde9d27..3c09c4a3d5d71 100644 --- a/superset/translations/zh/LC_MESSAGES/messages.json +++ b/superset/translations/zh/LC_MESSAGES/messages.json @@ -2824,8 +2824,8 @@ "Annotation Source": ["注释来源"], "No options": ["没有选项"], "Superset annotation": ["Superset注释"], - "Use a pre defined Superset Chart as a source for annotations and overlays. your chart must be one of these visualization types:": [ - "使用预定义的图表作为注释和覆盖的源。图表必须是以下可视化类型之一:" + "Use another existing chart as a source for annotations and overlays. Your chart must be one of these visualization types: [%s]": [ + "使用预定义的图表作为注释和覆盖的源。图表必须是以下可视化类型之一: [%s]" ], "Expects a formula with depending time parameter 'x'\n in milliseconds since epoch. mathjs is used to evaluate the formulas.\n Example: '2x+5'": [ "需要一个从Epoch(1970年1月1日00:00:00 UTC)时间点开始的时间参数“x”,并以此来计算的公式(以毫秒为单位)。我们使用“mathjs”来进行公式的计算。例如:'2x+5'"