Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency keys now have validation via Alias newtype. #164

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Dependency keys now have validation via Alias newtype. #164

wants to merge 3 commits into from

Conversation

u-train
Copy link
Contributor

@u-train u-train commented Jun 29, 2023

Relevant Changes

  • World Peace has been achieved.
    • Restrictions on Alias: must be a valid Lua identifier (alphanumeric ASCII + underscores + no leading digit) and not be harmful to the file system.
  • The Resolve graph from resolution now uses Alias to link dependencies together instead of strings.
    • This is a breaking change to the public API.
  • The lock file now uses Alias to name dependencies instead of strings.
    • This means old lock files will now be validated when they weren't before. There's an infinitesimal chance that someone will be uppity about this.
  • test_packages got alias adoption, it's happy, it's internal.
  • All tests are passing, yay!

@u-train
international adoption of alias
1dbceae 
finally, world peace via breaking changes
- the resolution graph now uses aliases instead of strings.
 * Public API change that is breaking.
- lockfile format will now use aliases instead of strings.
 * This means old lockfiles will now be validated, when they weren't
   before.
- test_packages got alias adoption, it's happy, it's internal.
- update had a format change lolz.

at least everything passed with flying colors.
@u-train
as_str is a very nice api to have
22cb7db
@u-train
Add some failing tests for alias
a69091a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@u-train