Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Inline CSS #107

Closed
WillStrohl opened this issue Feb 7, 2023 · 0 comments
Closed

Remove Inline CSS #107

WillStrohl opened this issue Feb 7, 2023 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@WillStrohl
Copy link
Contributor

Describe the bug

There is a bunch of inline CSS that we've allowed to be added to the HTML. All inline CSS that can be moved into a CSS file needs to be, instead of being nested (hard-coded) in the HTML tags.

Software Versions

  • DNN: N/A
  • Module: 01.01.01

To Reproduce

View the HTML template files. There are instances where the style attribute is used to help improve the design.

Expected behavior

CSS is only defined in the CSS files.

Screenshots

N/A

Error log

N/A

Additional context

After updating, the module should appear to be exactly the same in both function and UI/UX. Testing should be done in a new browser and/or with incognito and a cleared cache.

@WillStrohl WillStrohl added the bug Something isn't working label Feb 7, 2023
@WillStrohl WillStrohl added this to the 01.01.02 milestone Feb 7, 2023
@alejoroman0605 alejoroman0605 mentioned this issue Feb 13, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant