Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example tests don't run as part of CI #96

Open
chrisns opened this issue Dec 13, 2016 · 6 comments
Open

example tests don't run as part of CI #96

chrisns opened this issue Dec 13, 2016 · 6 comments

Comments

@chrisns
Copy link
Contributor

chrisns commented Dec 13, 2016

In example/ you've got codecept there, but the tests don't run as part of CI

@JoeChapman
Copy link
Contributor

@lennym @easternbloc ideas for how to do this nicely?

@lennym
Copy link
Contributor

lennym commented Jun 1, 2017

rm -rf example?

@JoeChapman
Copy link
Contributor

And any new examples? It's not a bad idea to run tests against the examples when HOF core changes

@lennym
Copy link
Contributor

lennym commented Jun 1, 2017

@JoeChapman
Copy link
Contributor

Yes those, the examples that don't have tests. Maybe they should have tests. However, if your point is "they don't have tests", then sure forget it. Close this issue

@lennym
Copy link
Contributor

lennym commented Jun 1, 2017

I think we should remove the example in this repo in favour of a single-source-of-truth in the other repo.

As for testing those examples... it's not a bad idea. It's just more work to be done. By all means add functional tests for examples when creating them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants