New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CXMLNode children] crash caused by adding nil object to NSMutableArray #38

Open

nobby-styles opened this issue Nov 11, 2013 · 0 comments

nobby-styles commented Nov 11, 2013

(NSArray *)children
{
NSAssert(_node != NULL, @"CXMLNode does not have attached libxml2 _node.");

NSMutableArray *theChildren = [NSMutableArray array];

if (_node->type != CXMLAttributeKind) // NSXML Attribs don't have children.
{
xmlNodePtr theCurrentNode = _node->children;
while (theCurrentNode != NULL)
{
CXMLNode *theNode = [CXMLNode nodeWithLibXMLNode:theCurrentNode freeOnDealloc:NO];
[theChildren addObject:theNode];// CRASH
theCurrentNode = theCurrentNode->next;
}
}
return(theChildren);
}

I suggest a check on theNode so if it is nil, it doesn't try add the object to the NSMutableArray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment