Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

rename duration to align with ytdl-core #155

Open
TimeForANinja opened this issue Mar 10, 2022 · 0 comments
Open

rename duration to align with ytdl-core #155

TimeForANinja opened this issue Mar 10, 2022 · 0 comments

Comments

@TimeForANinja
Copy link
Owner

for ytdl it's named lengthSeconds
https://github.com/fent/node-ytdl-core/blob/master/typings/index.d.ts#L126
for ytsr it's named duration https://github.com/TimeForANinja/node-ytsr/blob/master/typings/index.d.ts#L94
so it would make sense to rename it to length and also add a lengthSeconds

if doing this don't forget
GridMovie#duration => https://github.com/TimeForANinja/node-ytsr/blob/master/typings/index.d.ts#L142
Movie#duration => https://github.com/TimeForANinja/node-ytsr/blob/master/typings/index.d.ts#L163

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant