Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw UnauthorizedAccessException when replacing a read-only file on Windows #408

Merged
merged 2 commits into from
Oct 6, 2023
Merged

fix: throw UnauthorizedAccessException when replacing a read-only file on Windows #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d2af59
Fix attributes and exception when working with read-only files on Fil…
vbreuss Oct 6, 2023
d48e8bf
Adjust tests for MacOS
vbreuss Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Source/Testably.Abstractions.Testing/FileSystem/FileInfoMock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,8 @@ public IFileInfo Replace(string destinationFileName,
}

throw ExceptionFactory.DirectoryNotFound(FullName);
}))
}),
!Execute.IsWindows)
?? throw ExceptionFactory.FileNotFound(FullName);
return _fileSystem.FileInfo.New(location.FullPath);
}
Expand Down
23 changes: 18 additions & 5 deletions Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,11 +382,15 @@ public IStorageContainer GetOrCreateContainer(
throw ExceptionFactory.AccessToPathDenied(source.FullPath);
}

using (_ = sourceContainer.RequestAccess(FileAccess.ReadWrite, FileShare.None,
using (_ = sourceContainer.RequestAccess(
FileAccess.ReadWrite,
FileShare.None,
ignoreMetadataErrors: ignoreMetadataErrors))
{
using (_ = destinationContainer.RequestAccess(FileAccess.ReadWrite,
FileShare.None, ignoreMetadataErrors: ignoreMetadataErrors))
using (_ = destinationContainer.RequestAccess(
FileAccess.ReadWrite,
FileShare.None,
ignoreMetadataErrors: ignoreMetadataErrors))
{
if (_containers.TryRemove(destination,
out IStorageContainer? existingDestinationContainer))
Expand All @@ -412,8 +416,17 @@ public IStorageContainer GetOrCreateContainer(
Execute.OnWindowsIf(sourceContainer.Type == FileSystemTypes.File,
() =>
{
existingSourceContainer.Attributes |=
FileAttributes targetAttributes =
existingDestinationContainer.Attributes |
FileAttributes.Archive;
if (existingSourceContainer.Attributes.HasFlag(FileAttributes
.ReadOnly))
{
targetAttributes |= FileAttributes.ReadOnly;
}

existingSourceContainer.Attributes = targetAttributes;

existingSourceContainer.CreationTime.Set(
existingDestinationContainer.CreationTime.Get(
DateTimeKind.Utc),
Expand Down Expand Up @@ -502,7 +515,7 @@ public bool TryAddContainer(
return false;
}

#endregion
#endregion

/// <inheritdoc cref="object.ToString()" />
public override string ToString()
Expand Down
44 changes: 39 additions & 5 deletions Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/ReplaceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ public void
}

[SkippableTheory]
[InlineAutoData(FileAttributes.Hidden, FileAttributes.Hidden)]
[InlineAutoData(FileAttributes.System, FileAttributes.System)]
[InlineAutoData(FileAttributes.Hidden, FileAttributes.System)]
[InlineAutoData(FileAttributes.System, FileAttributes.Hidden)]
public void Replace_ShouldAddArchiveAttribute_OnWindows(
FileAttributes sourceFileAttributes,
FileAttributes destinationFileAttributes,
Expand Down Expand Up @@ -187,14 +187,48 @@ public void Replace_ShouldAddArchiveAttribute_OnWindows(

IFileInfo sut = FileSystem.FileInfo.New(sourceName);

sut.Replace(destinationName, backupName, true);
sut.Replace(destinationName, backupName);

FileSystem.File.GetAttributes(destinationName)
.Should().Be(expectedSourceAttributes);
if (Test.RunsOnMac)
{
FileSystem.File.GetAttributes(destinationName)
.Should().Be(expectedSourceAttributes);
}
else
{
FileSystem.File.GetAttributes(destinationName)
.Should().Be(expectedDestinationAttributes);
}
FileSystem.File.GetAttributes(backupName)
.Should().Be(expectedDestinationAttributes);
}

[SkippableTheory]
[AutoData]
public void Replace_WhenFileIsReadOnly_ShouldThrowUnauthorizedAccessException_OnWindows(
string sourceName,
string destinationName,
string backupName,
string sourceContents,
string destinationContents)
{
Skip.IfNot(Test.RunsOnWindows);

FileSystem.File.WriteAllText(sourceName, sourceContents);

FileSystem.File.WriteAllText(destinationName, destinationContents);
FileSystem.File.SetAttributes(destinationName, FileAttributes.ReadOnly);

IFileInfo sut = FileSystem.FileInfo.New(sourceName);

Exception? exception = Record.Exception(() =>
{
sut.Replace(destinationName, backupName);
});

exception.Should().BeException<UnauthorizedAccessException>(hResult: -2147024891);
}

[SkippableTheory]
[AutoData]
public void Replace_ShouldKeepMetadata(
Expand Down
Loading