-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility on Cards. #86
Merged
JulianAlonso
merged 24 commits into
main
from
apps/cards_as_unique_element_for_voiceover
Feb 23, 2021
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
86ff560
set accesibilityElement to Card when it has no buttons
10a1920
remove white line
ef8d022
Run swiftformat
JulianAlonso beb70ba
improve Cards accessibility
50a52c6
swift format
68eb58c
override traits to cards
a7cb59e
swiftformat
2a3b705
merge from main
cd1e56e
Run swiftformat
JulianAlonso 49331b3
IOS-6513 Update components list of main README
jmbrocal 6f23f8e
IOS-6513 Move HighlightedCard to Components/Cards folder and update R…
jmbrocal 00cf8d4
IOS-6513 Improve linking to cards components
jmbrocal 23926d6
Apply suggestions from code review
jmbrocal cf47ab7
set accesibilityElement to Card when it has no buttons
d26dd3c
remove white line
6ca5919
improve Cards accessibility
7e00a64
Run swiftformat
JulianAlonso f482d8d
override traits to cards
ea9e666
swiftformat
f5f4e82
Improve accessibility on cards.
ee71299
update cards documentation
fac7255
add accessibility docs to Cards docs
1524d95
merge from githun
fcb2b17
update with main
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this cast?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid the Xcode warning about your implicitly casting from N to Any.