fix(HighlightedCard): set multi lines support for both texts (title a… #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd subtitle) BREAKING CHANGE: texts (title and subtitle) of HighlightedCard has no restrictions of number of lines and both support multi lines.
jmbrocal
requested review from
a team,
salavert,
pbartolome and
jmpg93
and removed request for
a team and
pbartolome
jmpg93
approved these changes
Feb 4, 2021
salavert
approved these changes
Feb 4, 2021
jmbrocal
deleted the
jmbrocal/highlightedCard-remove-number-of-lines-restriction
branch
tuentisre
pushed a commit
that referenced
this pull request
Feb 17, 2021
# [9.0.0](v8.0.1...v9.0.0) (2021-02-17) ### Bug Fixes * **Button:** Make Button a UIControl BREAKING CHANGE: Button.State enum has changed to UIControl.State. ([#79](#79)) ([4b57222](4b57222)) * **ColorPalette:** fix backgroundPromo color of O2ClassicColorPalette ([#75](#75)) ([fd87da0](fd87da0)) * **DataCard:** fix border color of card ([cb4c3b0](cb4c3b0)) * **HighlightedCard:** add support for xib and storyboard ([5e3afa7](5e3afa7)) * **HighlightedCard:** fix showActionButton and showCloseButton so that the value of the variables makes sense in English ([b6a2921](b6a2921)) * **HighlightedCard:** nake init with parameters: `(title:subtitle:rightImage:actionButtonStyle:)` configures the correct styles. ([31f2bf6](31f2bf6)) * **HighlightedCard:** set multi lines support for both texts (title and subtitle) ([#77](#77)) ([657a3bc](657a3bc)) * **HighlightedCard,MediaCard,MediaCard,Stepper:** fix border color by replacing "divider" by "border" of the color palette and set the border size to 1 px ([66e4aae](66e4aae)) * **MediaCard:** fix border color of card and vertical spacing after headline ([f62b6f2](f62b6f2)) * **Stepper:** Update Lottie stroke width ([#76](#76)) ([0c9a35f](0c9a35f)) ### BREAKING CHANGES * **HighlightedCard:** texts (title and subtitle) of HighlightedCard have no restrictions of number of lines and both add support multi lines.
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks!
In the last meeting with design core, we decide to remove limitations about number of lines in some components (like cards, list, etc).
For the iOS version of Mistica, we have only to change HighlightedCard
Enjoy