IOS-9794 VIVO Novo app accessibility: Bottom sheet formats #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added AccessibilityElementType enum
…yTraits instead) Renamed itemAccessibilityLabel to accessibilityLabel Set accessibilityTraits = .link for ActionRow's Set accessibilityTraits = .button for backgroundDimmingView in BottomSheetPresentationController
…e accessibility uses the title and the type is added with the accessibilityTraits
amegias
approved these changes
Apr 11, 2024
alejandroruizponce
approved these changes
Apr 11, 2024
dhidalgofadrique
deleted the
IOS-9794-VIVO-Novo-app-accessibility-Bottom-sheet-formats
branch
|
🎉 This PR is included in version 29.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
IOS-9794 VIVO Novo app accessibility: Bottom sheet formats
🥅 What's the goal?
🚧 How do we do it?
Added accessibilityTraits to both elements:
.linkfor ActionRow's.buttonfor backgroundDimmingViewThis way VoiceOver will read both elements appending the trait (button or link) at the end
You can find more info about accessibility here: iOS Accessibility
🧪 How can I verify this?
Activate VoiceOver and check that after each element it speaks "link" and after close element speaks "close".
Accessibility_sheets.mp4
NOTE: The language of the trait (link, button) will be the user defined language. The language management will be done in the app by setting the
accessibilityLanguagein each OB.