fix(Version): Fix mistica version and catalog version #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmpg93
requested review from
DavidMarinCalleja and
jmbrocal
and removed request for
a team
DavidMarinCalleja
previously approved these changes
Aug 12, 2022
|
Sorry @DavidMarinCalleja, I've stale your review. I've added dark mode assets as requested by @yceballost |
| @@ -95,7 +95,7 @@ struct Searchable: ViewModifier { | |||
|
|
|||
| extension UIImage { | |||
| func bordered(borderWidth: CGFloat = 1, color: UIColor) -> UIImage { | |||
| UIGraphicsBeginImageContext(size) | |||
| UIGraphicsBeginImageContextWithOptions(size, false, UIScreen.main.scale) | |||
There was a problem hiding this comment.
Just out of curiosity, why do we need to set this option (UIScreen.main.scale) now?
There was a problem hiding this comment.
Because we need to take the scale into account for core graphics to render the image properly. I didn't notice until installing in a real device.
DavidMarinCalleja
approved these changes
Aug 12, 2022
jmbrocal
approved these changes
Aug 16, 2022
tuentisre
pushed a commit
that referenced
this pull request
Aug 31, 2022
## [18.0.1](v18.0.0...v18.0.1) (2022-08-31) ### Bug Fixes * **Assets:** IOS-7644 Exclude common assets from protocol ([#211](#211)) ([e664ecc](e664ecc)) * **SwiftUI:** Fix navigation bar back tint color for iOS 16 ([7eca013](7eca013)) * **Version:** Fix mistica version and catalog version ([#209](#209)) ([a3aaffa](a3aaffa))
|
🎉 This PR is included in version 18.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I'm fixing the mistica catalog version and mistica version.
I'm also updating the script to update version which seems to be working wrong.