IOS-9479 Fix URL extension to be internal instead of public to avoid … #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…possible collisions with other implementations.
DavidMarinCalleja
approved these changes
Nov 2, 2023
alejandroruizponce
approved these changes
Nov 2, 2023
tuentisre
pushed a commit
that referenced
this pull request
Nov 2, 2023
## [26.4.1](v26.4.0...v26.4.1) (2023-11-02) ### Bug Fixes * **URL:** Fix URL extension to be internal instead of public to avoid possible collisions with other implementations ([9b4e0cc](9b4e0cc)), closes [#321](#321)
|
🎉 This PR is included in version 26.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
IOS-9479 Make URL(urlString:) init method as internal to avoid collisions with other implementations.
🥅 What's the goal?
Avoid collisions with other implementations of this method and do not expose URL extensions from Mistica.
🚧 How do we do it?
I made the extension internal.
🧪 How can I verify this?
🏑 AppCenter build