IOS-9013 Combine mistica into a single package to prevent duplicated symbols when importing Mistica and MisticaSwiftUI #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…symbols when importing Mistica and MisticaSwiftUI
pbartolome
requested review from
a team,
salavert and
idenjoe
and removed request for
a team
salavert
approved these changes
May 29, 2023
idenjoe
approved these changes
May 30, 2023
tuentisre
pushed a commit
that referenced
this pull request
May 30, 2023
# [25.0.0](v24.0.0...v25.0.0) (2023-05-30) ### chore * **SPM:** IOS-9013 Combine mistica into a single package to prevent duplicated symbols when importing Mistica and MisticaSwiftUI ([#283](#283)) ([10179e6](10179e6)) ### BREAKING CHANGES * **SPM:** Mistica package now contains MisticaSwiftUI and Mistica for UIKit, imports of MisticaSwiftUI will need to be changed to import Mistica
|
🎉 This PR is included in version 25.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
IOS-9013
🥅 What's the goal?
As explained in the document https://confluence.tid.es/display/CTO/%5BAPPS%5D+Shared+Spec%3A+Mistica+iOS+issues+with+duplicated+symbols, the current
Package.swiftcreates two librariesMisticaandMisticaSwiftUIwith the sameMisticaCommoncode added to each library. This causes duplicated symbols and unexpected behaviour when importing the two libraries in the same target.🚧 How do we do it?
Combine all Modules into a single
Misticalibrary.🧪 How can I verify this?
Run and build a project that uses Mistica and MisticaSwiftUI (E.g. MisticaCatalog), check that there are no longer duplicated symbols.