IOS-8051 Build Mistica with XCode 14.2 #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gomay88
approved these changes
Feb 8, 2023
alexanegon
approved these changes
Feb 8, 2023
alejandroruizponce
approved these changes
Feb 8, 2023
|
LGTM
As a solution we can move the screen recording to CI so we are sure that we always use the same machine type. IMHO I would try to avoid to reduce the precision as much as we can because we can introduce false positives. |
jmbrocal
approved these changes
Feb 10, 2023
That's a good point. Anyway, here I just update the XCode and the mac architecture didn't affect. |
tuentisre
pushed a commit
that referenced
this pull request
Feb 10, 2023
# [20.2.0](v20.1.1...v20.2.0) (2023-02-10) ### Features * **XCode:** Update to XCode 14.2 ([#245](#245)) ([3d464cd](3d464cd))
|
🎉 This PR is included in version 20.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have installed XCode 14.2 in our CI/CD machines, I've taken advantage of updating the project.
https://jira.tid.es/browse/IOS-8051
How did I do??
🔴 Tests failed! -> Using a new iOS (16.2), some (23) tests must be re-recorded.
https://github.com/Telefonica/mistica-ios/actions/runs/4111995046/jobs/7096380118
🔵 Tests passed 🥳
NOTE: These 23 failed tests have been recorded again with a M1 laptop. Fortunately, the new screenshots matched with the test ones generated in CI (Intel).
More info here:
https://teams.microsoft.com/l/message/19:40b9dabcaf1a4abea1216117ac7c0596@thread.tacv2/1675700621115?tenantId=9744600e-3e04-492e-baa1-25ec245c6f10&groupId=992881f8-bbab-4891-8c17-ffe99ba6f43b&parentMessageId=1675700621115&teamName=Apps%20Team&channelName=iOS&createdTime=1675700621115&allowXTenantAccess=false