fix(Prominent): Fix prominent theme colors for Movistar #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmpg93
commented
Aug 1, 2022
| let navigationBarBackground = MovistarColorPalette.movistarBlue | MovistarColorPalette.darkModeBlack | ||
| var navigationBarBackground: UIColor { MovistarColorPalette.movistarBlueWithProminentVariant | MovistarColorPalette.darkModeBlack } |
There was a problem hiding this comment.
We need to use computed properties. Otherwise, the prominent color will be wrong.
There was a problem hiding this comment.
should we state some kind of premises so other will have this problem into account in the future?
There was a problem hiding this comment.
Talked offline. The best option for this to not happen again is to create tests for prominent. I've create this ticket to https://jira.tid.es/browse/IOS-7587 tackle it down at some point.
jmpg93
requested review from
a team,
salavert and
alexanegon
and removed request for
a team
jmpg93
changed the title
…a/mistica-ios into fix/movistar-prominent-variant
alexanegon
approved these changes
Aug 1, 2022
salavert
approved these changes
Aug 1, 2022
jmpg93
changed the title
|
🎉 This PR is included in version 17.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I'm fixing prominent variant colors for Movistar using the latests definition of design.
It broke while aligning the colors of mistica with android and web a few weeks ago.