fix(EmptyState): Missing accesiblity IDS in Empty state. Fix wrong color on InputField borders - SMARTWIFI-3416 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbartolome
requested review from
a team,
DavidMarinCalleja and
alexanegon
and removed request for
a team
|
Screenshot tests report ✔️ All passing |
pbartolome
force-pushed
the
sw/mistica-issues-14.2.1
branch
from
9052b12
to
8b19af5
Compare
| @@ -113,6 +104,7 @@ extension EmptyStateContentBase { | |||
| iconImage.accessibilityIdentifier | |||
| } | |||
| set { | |||
| iconImage.isAccessibilityElement = true | |||
There was a problem hiding this comment.
I didn't know this property, good work!
DavidMarinCalleja
approved these changes
Jan 26, 2022
alexanegon
approved these changes
Jan 27, 2022
tuentisre
pushed a commit
that referenced
this pull request
Feb 15, 2022
# [15.2.0](v15.1.0...v15.2.0) (2022-02-15) ### Bug Fixes * **EmptyState:** Missing accesiblity IDS in Empty state. Fix wrong color on InputField borders - SMARTWIFI-3416 ([#161](#161)) ([4c61058](4c61058)) ### Features * **Feedback:** IOS-7228 Updating feedback success/error lottie animations ([#164](#164)) ([bb378eb](bb378eb))
|
🎉 This PR is included in version 15.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appium, wasn't able to see elements in the EmptyState as the accesibility elements were being overriden with the
accessibilityElementsarray. With these fixes now Appium can detect all elements inside the EmptyState, and voiceover still reads the text as a single element (it doesn't jump from one label to the next)InputField.swiftwas using the incorrect color for the borderThis code will be used to generate a "maintenance" mistica version v14.2.1, this PR is to add the fix also in
main