feat(Controls): Update Checkbox and RadioButton animations #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Mistica/Source/Components/Checkbox/Checkbox.swift # Mistica/Source/Components/RadioButton/RadioButton.swift # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxActiveCheckedState.with-movistar-dark-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxActiveCheckedState.with-movistar-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxActiveCheckedState.with-o2-dark-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxActiveCheckedState.with-o2-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxActiveCheckedState.with-o2Classic-dark-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxActiveCheckedState.with-o2Classic-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxActiveCheckedState.with-vivo-dark-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxActiveCheckedState.with-vivo-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxDefaultState.with-movistar-dark-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxDefaultState.with-movistar-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxDefaultState.with-o2-dark-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxDefaultState.with-o2-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxDefaultState.with-o2Classic-dark-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxDefaultState.with-o2Classic-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxDefaultState.with-vivo-dark-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxDefaultState.with-vivo-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxIsChecked.assertInitialState.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testCheckboxIsChecked.finalState.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/CheckboxTests/testXIBIntegration.1.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/RadioButtonTests/testRadioButtonEnabled.with-movistar-dark-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/RadioButtonTests/testRadioButtonEnabled.with-o2-dark-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/RadioButtonTests/testRadioButtonEnabled.with-o2Classic-dark-style.png # Mistica/Tests/MisticaTests/UI/__Snapshots__/RadioButtonTests/testRadioButtonEnabled.with-vivo-dark-style.png # MisticaCatalog/Source/ComponentsCatalogs/UICatalogControlsViewController.swift
jmpg93
requested review from
a team,
victorpimentel and
pbartolome
and removed request for
a team
|
|
That was a nice catch. It seems that the transform is lost when changing userInterfaceStyle. I have update the animation to change the opacity of the layer (so we do not rely in the transform). Thanks! |
…fonica/mistica-ios into IOS-6669-update-checkbox-animations # Conflicts: # Mistica/Source/Components/Checkbox/Checkbox.swift
pbartolome
approved these changes
May 5, 2021
victorpimentel
approved these changes
May 10, 2021
tuentisre
pushed a commit
that referenced
this pull request
Jul 1, 2021
# [11.3.0](v11.2.0...v11.3.0) (2021-07-01) ### Features * **Controls:** Update Checkbox and RadioButton animations ([#112](#112)) ([ff570de](ff570de))
|
🎉 This PR is included in version 11.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
IOS-6669 Checkbox control evolution
🥅 What's the goal?
Add animation as defined by Zepplin (linked video).
🚧 How do we do it
Update Checkbox and RadioButton properties to support CALayer animations.
🧪 How can I test this?
Downloading the catalog and see the new animations under controls section.
🏑 AppCenter build
📱 Demo
RPReplay_Final1620116444.MP4