IOS 6669 Make Checkbox Squared. #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmpg93
requested review from
DavidMarinCalleja and
cbarcom
and removed request for
a team
Comment on lines
100
to
109
| func isCheckedChanged(checked: Bool) { | ||
| if checked { | ||
| imageView.image = UIImage(named: "icn_checkbox_on", type: .brandedAndThemed) | ||
| imageView.image = UIImage(named: "icn_checkbox_check", type: .common) | ||
| removeBorder() | ||
| imageView.backgroundColor = .controlActivated | ||
| } else { | ||
| imageView.image = UIImage(named: "icn_checkbox_off", type: .common) | ||
| imageView.image = nil | ||
| addBorder(color: .control) | ||
| imageView.backgroundColor = .clear | ||
| } |
There was a problem hiding this comment.
It might make sense to change to property? this way it could be used as
isCheckedChanged = false
There was a problem hiding this comment.
There is a isChecked property already, this the method to be called when the property changes.
Not sure if that is what yo mean.
There was a problem hiding this comment.
I rather meant that I was confused by the name, I think we had agreed that functions of type isXXX should return a bool value or be a property.
There was a problem hiding this comment.
I will use checkedValueChanged as talked offline.
DavidMarinCalleja
previously approved these changes
Apr 28, 2021
yceballost
requested changes
Apr 28, 2021
DavidMarinCalleja
previously approved these changes
Apr 28, 2021
yceballost
approved these changes
Apr 29, 2021
cbarcom
approved these changes
Apr 29, 2021
DavidMarinCalleja
approved these changes
May 4, 2021
tuentisre
pushed a commit
that referenced
this pull request
May 5, 2021
|
🎉 This PR is included in version 11.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make the checkbox squared according to the new typology: https://app.zeplin.io/project/5d653c69f828bf7299c551c1/screen/5f5f84d1059b75441dcf9280
I've update the catalog with this changes, in case you want to check it in a device.
I'm also removing a couple of colors constants we do not need anymore.