Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOS-6545 Dark mode updates #110

Merged
merged 8 commits into from
Apr 28, 2021
Merged

IOS-6545 Dark mode updates #110

merged 8 commits into from
Apr 28, 2021

Conversation

jmpg93
Copy link
Contributor

@jmpg93 jmpg93 commented Apr 27, 2021

Add background color to ListViewCell.

Useful for boxed cell in dark mode, as they are containers inside the cells.

@jmpg93 jmpg93 requested a review from a team April 27, 2021 08:47
@jmpg93 jmpg93 self-assigned this Apr 27, 2021
@jmpg93 jmpg93 requested review from salavert and jmbrocal and removed request for a team April 27, 2021 08:47
jmbrocal
jmbrocal approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@jmbrocal jmbrocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

200

@jmpg93 jmpg93 merged commit 91b22b2 into main Apr 28, 2021
@jmpg93 jmpg93 deleted the IOS-6545-darkmode-updates branch April 28, 2021 10:42
tuentisre pushed a commit that referenced this pull request Apr 28, 2021
@semantic-release-bot
chore(release): 11.1.2 [skip ci]
d5578ab 
## [11.1.2](v11.1.1...v11.1.2) (2021-04-28)

### Bug Fixes

* **DarkMode:** Fix dark mode colors in classic o2 ([#109](#109)) ([7e6a7f6](7e6a7f6))
* **DarkMode:** Update backgroundColor of ListViewCell ([#110](#110)) ([91b22b2](91b22b2))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 11.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salavert salavert salavert approved these changes

@jmbrocal jmbrocal jmbrocal approved these changes

Assignees

@jmpg93 jmpg93

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmpg93 @tuentisre @salavert @jmbrocal