Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract uploader information into seperate DB table out of stream table #6924

Open
3 tasks done
XiangRongLin opened this issue Aug 14, 2021 · 1 comment
Open
3 tasks done
Labels
codequality Improvements to the codebase to improve the code quality

Comments

@XiangRongLin
Copy link
Collaborator

Checklist


@ColumnInfo(name = STREAM_UPLOADER_URL)
var uploaderUrl: String? = null,

The uploader name is saved inside the streams table. This causes it to be duplicated for each occurence.
With the addition of the url of the uploader (#6919) it makes sense to extract both fields into a seperate table for uploaders and reference it.

The uploader names must to be migrated and the urls should ideally be migrated.


@ktprograms Am i correct in my assesment, that in theory not migrating the url, would only cause some loading extra loading times?

@XiangRongLin XiangRongLin added the codequality Improvements to the codebase to improve the code quality label Aug 14, 2021
@ktprograms
Copy link
Contributor

The uploader url isn't currently in the database. So newly saved videos will insert the url, and for old videos the code fetches it using the extractor, then saves it to the database for the next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

No branches or pull requests

2 participants