Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In non-full-screen, vertical drags occasionally change volume or brightness #4142

Closed
nyanpasu64 opened this issue Aug 16, 2020 · 1 comment · Fixed by #4223
Closed

In non-full-screen, vertical drags occasionally change volume or brightness #4142

nyanpasu64 opened this issue Aug 16, 2020 · 1 comment · Fixed by #4223
Labels
bug Issue is related to a bug

Comments

@nyanpasu64
Copy link
Contributor

nyanpasu64 commented Aug 16, 2020

Version

I found this bug on #4121 (comment) (a slightly modified build from today), and reproduced the issue in e9d4303 (latest dev).

Steps to reproduce the bug

  • Install recent dev build with unified player.
  • Open a video in the main player, in portrait mode (split between the player and description).
  • With the seek bar hidden (didn't test with it visible), drag the left or right side of the screen vertically.

Expected behavior

Usually, if you drag the video up, it does nothing, but holding your finger and dragging down minimizes the video. If you drag the video down, it immediately minimizes it. It's self-consistent, but you can't scroll the video up by dragging the video body, which I don't know if it's intentional.

Actual behaviour

Around 20% of the time, it changes the brightness or volume for a split second before scrolling. This is demonstrated in my video, before 0:23.

Screenshots/Screen recordings

https://youtu.be/CZKbFxFZxqc

I'm on a Moto G5 Plus running Android 8.1.0.

This bug may be somewhat related to #4121 . I found #4143 while experimenting with this bug.

@opusforlife2
Copy link
Collaborator

I'll do one better and show how you can reproduce this consistently. 😆

Hold down your finger on any area other than the video (except the area showing views, likes and dislikes, for some strange reason). Then quickly swipe on the video with another finger. Viola. Volume and brightness gestures galore. You can only do this once, though. If you stop adjusting and lift your finger, you'll have to lift and hold down your other finger again.

So I suspect another finger of yours happens to touch the screen accidentally when you swipe and successfully change volume/brightness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants