Password hashing - multiple encoders support #10080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
added
Potential Bug
pamil
changed the title
pamil
changed the title
Zales0123
approved these changes
Jan 10, 2019
lchrusciel
approved these changes
Jan 10, 2019
1 task
pamil
added a commit
that referenced
this pull request
Jan 11, 2019
This PR was merged into the 1.4-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | closes #9560, related to #10080 | License | MIT TODO: - [x] Functional test at the application level which updates the encoder and password of logged in user <!-- - Bug fixes must be submitted against the 1.2 or 1.3 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set --> Commits ------- d05d8aa Specify an listener to update the encoded password on login e58b202 Register the listener updating users' encoder b79be03 Add encoder name to serialised user data 93d7aed Add functional test for update password encoder listener 722ba00 Set "argon2i" as the default encoder f2e6896 Setup seamless change to argon2i d02581b Make test compatibile with Symfony 3.4 62eb4ab Mock what you own in encoder listener spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It reverses the BC break made in #10008 which forced end-users to change their security settings. This PR makes it opt-in for old installations and is enabled by default for new ones.