avoid setting JD globally? Just find DeltaT and call

[todo]

stellarium/src/gui/AstroCalcDialog.cpp

Lines 4971 to 4975 in 56653c2

	// TODO: avoid setting JD globally? Just find DeltaT and call
	// return object1->getHeliocentricEclipticPos(JDE).length();
	core->setJD(JD);
	core->update(0);
	return object1->getHeliocentricEclipticPos().length();

---

This issue was generated by todo based on a TODO comment in 56653c2. It's been assigned to @gzotti because they committed the code.

[gzotti]

@alex-w I just cannot decide at this point whether the side effect of setJD to the whole program wanted or not?

[alex-w]

@alex-w I just cannot decide at this point whether the side effect of setJD to the whole program wanted or not?

Probably this method may have once line - return object1->getHeliocentricEclipticPos(JD).length(); - but I fear we may catch a caching issue. Just try change it and compare the data with previous edition.

[alex-w]

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest