Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current year in Czech translation of meteor showers search dialog is not displayed #1854

Closed
margre8 opened this issue Aug 30, 2021 · 4 comments
Closed

Current year in Czech translation of meteor showers search dialog is not displayed #1854

margre8 opened this issue Aug 30, 2021 · 4 comments
Assignees
@alex-w
Labels
bug Something likely wrong in the code importance: medium A bit annoying, minor miscalculation, but no crash
Milestone
0.21.2

Comments

@margre8
Copy link

margre8 commented Aug 30, 2021

Expected Behaviour

Complete current date is displayed in meteor shower search dialog.

Actual Behaviour

In the place of year is displayed rrrr
Snímek z 2021-08-30 22-06-39

Steps to reproduce

Set Czech translation and start meteor shower search dialog.
I found out this issue can by solved by replacing msgstr dd/MM/rrrr by msgstr dd/MM/yyyy in the /po/Stellarium/cs.po file.

#: plugins/MeteorShowers/src/ui_MSSearchDialog.h:193
#: plugins/MeteorShowers/src/ui_MSSearchDialog.h:195
msgid "dd/MM/yyyy"
msgstr "dd/MM/rrrr"

System:

  • Stellarium version: 0.21.1
@gzotti
Copy link
Member

gzotti commented Aug 30, 2021

Somebody apparently translated a formatting string. 8-O Umm, @alex-w why is the formatting string translatable?

@gzotti gzotti added this to the 0.21.2 milestone Aug 30, 2021
@gzotti gzotti added the importance: medium A bit annoying, minor miscalculation, but no crash label Aug 30, 2021
@alex-w alex-w self-assigned this Aug 31, 2021
@alex-w alex-w added the bug Something likely wrong in the code label Aug 31, 2021
@alex-w alex-w closed this as completed in 44a0929 Aug 31, 2021
@alex-w
Copy link
Member

alex-w commented Aug 31, 2021

why is the formatting string translatable?

It was not marked as "no translatable"

@github-actions
Copy link

github-actions bot commented Sep 5, 2021

Hello @margre8! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@github-actions
Copy link

Hello @margre8! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-w alex-w

Labels
bug Something likely wrong in the code importance: medium A bit annoying, minor miscalculation, but no crash
Milestone
0.21.2
Development

No branches or pull requests
3 participants
@alex-w @gzotti @margre8