Oculars: ignoring 'Binocular' setting in Eyepieces tab, showing wrong UI texts

[joberreiter]

When the first entry of the eyepieces tab is of 'Binocular' type, the Oculars plugin shows wrong UI texts.

Expected Behaviour

On opening the settings dialog within Oculars and selecting the eyepieces tab, I would expect this for binoculars:

Actual Behaviour

On opening the settings dialog within Oculars and selecting the eyepieces tab, there is:

Steps to reproduce

• Activate Oculars (Ctrl-O)
• Click on the settings icon to bring up the settings dialog
• At the eyepieces tab, at the first entry, check the 'Binocular' setting. If there is no entry, create it (values don't matter), and check the 'binocular' type.
• Close and restart Stellarium (not sure if that is necessary!)
• Activate Oculars (Ctrl-O)
• Click on the settings icon to bring up the settings dialog
• Click on the 'Eyepieces' tab to show the eyepieces list

System

• Stellarium version: stellarium-0.21.0-win64.exe
• Operating system: MS Windows 7 SP1 (= v6.1) , 64bit, language german, region "de-de"
• Graphics Card: NVIDIA GeForce GTX 760, driver 466.11-desktop-win8-win7-64bit-international-whql.exe
• Screen type (if applicable): 2x 23" 16:10 @ 3360x1050px (32:10)

Logfile

log.txt

[github-actions]

Thanks for adding your first issue to Stellarium. If you have questions, please do not hesitate to contact us.

[alex-w]

I cannot reproduce the issue

[alex-w]

Please share your oculars.ini file

[joberreiter]

Of course:
ocular.ini.txt

I have to rename it, because github is configured not to allow to upload *.ini files.

[joberreiter]

May it be that the sequence of the ini-file entries starting with "<number>\" does matter?
And if the numbered lines are not perfectly sorted (by number), the read out of the ini-entries fails (and the settings get their default values)?
Like:

0\name=Oly 8x42 EXPS1
0\afov=6.5
0\efl=8
0\fieldstop=42
0\permanentCrosshair=false
0\reticlePath=
1\name=Nikon Aculon 10-22x50 @ 10
1\afov=36.7
1\efl=10
1\fieldstop=50
1\permanentCrosshair=false
1\reticlePath=
0\binoculars=true     # <-- Note this line!
1\binoculars=true

Maybe it is then related to #1684 ?

[gzotti]

The Oculars plugin currently undergoes a major revision. Hopefully this will be then solved.

[github-actions]

Hello @joberreiter! OK, developers can reproduce the issue. Thanks for the report!

[github-actions]

Hello @joberreiter! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

[github-actions]

Hello @joberreiter! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest