Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multisampling is broken on Linux #1553

Closed
10110111 opened this issue Mar 17, 2021 · 5 comments
Closed

Multisampling is broken on Linux #1553

10110111 opened this issue Mar 17, 2021 · 5 comments
Assignees
Labels
bug Something likely wrong in the code
Milestone

Comments

@10110111
Copy link
Contributor

Linux never has ENABLE_SPOUT defined, while current check for the qApp property compares the property value to "none", while actual value is absent (gets converted to ""). This results in multisampling being always disabled on Linux (actually, on everything !WIN32).

@alex-w alex-w added the bug Something likely wrong in the code label Mar 17, 2021
@alex-w alex-w added this to the 0.21.0 milestone Mar 17, 2021
@10110111
Copy link
Contributor Author

This change would fix it, but I'm not sure if it's the best approach.

diff --git a/src/CLIProcessor.cpp b/src/CLIProcessor.cpp
index 99dc9ac3e2..50dc64031d 100644
--- a/src/CLIProcessor.cpp
+++ b/src/CLIProcessor.cpp
@@ -303,6 +303,8 @@ void CLIProcessor::parseCLIArgsPostConfig(const QStringList& argList, QSettings*
         qApp->setProperty("spout", "none");
     if (!spoutName.isEmpty())
         qApp->setProperty("spoutName", spoutName);
+#else
+    qApp->setProperty("spout", "none");
 #endif
 }
 

@gzotti
Copy link
Member

gzotti commented Mar 17, 2021

Ah, right...

@gzotti gzotti self-assigned this Mar 17, 2021
@gzotti gzotti closed this as completed in 19c50a4 Mar 17, 2021
@gzotti
Copy link
Member

gzotti commented Mar 17, 2021

Thanks. This is one of maybe 3 ways to do it, and reasonably simple.

@github-actions
Copy link

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@github-actions
Copy link

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something likely wrong in the code
Development

No branches or pull requests

3 participants