Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement generate_assets_ouput for Application Import #33

Open
TamimiGitHub opened this issue Feb 9, 2023 · 0 comments
Open

Implement generate_assets_ouput for Application Import #33

TamimiGitHub opened this issue Feb 9, 2023 · 0 comments

Comments

@TamimiGitHub
Copy link
Collaborator

TamimiGitHub commented Feb 9, 2023

Current Behaviour

The current behaviour of the importer that assets are generated in the output directly for Event APIs only. Even when the Application mode is set to true (CLI_IMPORT_CREATE_API_APPLICATION=true) the output directory tmp/output/{domain_name}/{application_name} contains asyncapi spec file for EventAPIs

Proposal

  1. Implement cliApplicationVersionImporterGenerateAssetsReturn in CliApplicationImporter.ts that uses getAsyncApiForApplicationVersion
  2. Generate asset output for the respected import asset mode. For example, generate Application assets for CLI_IMPORT_CREATE_API_APPLICATION=true otherwise generate generate assets for event API import

End Goal

Recommit the asyncapi spec for the newly importer Application/Event back to the original repo to make sure repo and EP are in sync.

Importer Version

v0.52.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant